Bookkeeping and tweaking

models/game.js

@@ -9,10 +9,13 @@
 
 import { isIdSane, miniUid } from "../utils/id.js";
 import { Xorshift32 } from "../utils/random.js";
-import { Character } from "./character.js";
+import { ItemBlueprint } from "./item.js";
-import { ItemAttributes, ItemBlueprint } from "./item.js";
 import { Player } from "./player.js";
 
+/** @typedef {import("./character.js").Character} Character */
+/** @typedef {import("./item.js").ItemAttributes} ItemAttributes */
+/** @typedef {import("./item.js").ItemBlueprint} ItemBlueprint */
+
 export class Game {
     _counter = 1_000_000;
 
@@ -117,10 +120,8 @@ export class Game {
      */
     getItemBlueprint(blueprintId) {
         if (!isIdSane(blueprintId)) {
-            throw new Error(`blueprintId >>${blueprintId}<< is insane!`);
+            throw new Error(`blueprintId >>${blueprintId}<< is not a valid id`);
         }
-        const tpl = this._itemBlueprints.get(blueprintId);
+        return this._itemBlueprints.get(blueprintId);
-
-        return tpl || undefined;
     }
 }

models/portal.js

@@ -4,22 +4,20 @@
  * Example: two adjacent rooms connected by a door:
  *          Room A has a portal to Room B, and
  *          Room B has a portal to Room A.
- *
- *  @todo Add encounters to portals
  */
 export class Portal {
-  /**
+    /**
-   * Target Location.
+     * Target Location.
-   */
+     */
-  _targetLocationId;
+    _targetLocationId;
 
-  /**
+    /**
-   * Description shown to the player when they inspect the portal from the source location.
+     * Description shown to the player when they inspect the portal from the source location.
-   */
+     */
-  _description;
+    _description;
 
-  /**
+    /**
-   * Description shown to the player when they traverse the portal.
+     * Description shown to the player when they traverse the portal.
-   */
+     */
-  _traversalDescription;
+    _traversalDescription;
 }

models/session.js

@@ -1,10 +1,10 @@
-import WebSocket from "ws";
 import { Player } from "./player.js";
 import { mustBeString, mustBe } from "../utils/mustbe.js";
 import { Scene } from "../scenes/scene.js";
-import { gGame } from "./globals.js";
 import { formatMessage, MessageType } from "../utils/messages.js";
 
+/** @typedef {import("ws").WebSocket} WebSocket */
+
 export class Session {
     /** @type {WebSocket} */
     _websocket;